MU WPCOM: dashboard: add launchpad #41138

ellatrix · 2025-01-16T20:39:04Z

Note

It's not really +1000 LoC! That's just the package lock file. 😊

See Automattic/wp-calypso#95386.

Proposed changes:

Add the launchpad component as a widget to the dashboard.
Minor adjustments to styling so it fits with wp-admin.

See #39806 for some prior work.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

With classic style admin enabled (Settings > General), create a new (unlaunched) site, and test the links in the Dashboard widget.
It should not appear for launched sites.
Test the links.
Test launching a site (make sure to enable read-write)

github-actions · 2025-01-16T20:40:00Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Mu Wpcom plugin:

Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2025-01-16T20:50:12Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/dashboard-launch-steps branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/dashboard-launch-steps

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/dashboard-launch-steps

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

ellatrix · 2025-01-22T15:07:49Z

projects/packages/jetpack-mu-wpcom/webpack.config.js

+			fallback: {
+				...jetpackWebpackConfig.resolve.fallback,
+				events: require.resolve( 'events/' ),
+			},


I've taken these changes from the previous PR: #39806

What is it about?

ellatrix · 2025-01-23T16:08:25Z

...-wpcom/src/features/wpcom-dashboard-widgets/wpcom-launchpad-widget/celebrate-launch-modal.js

I transplanted this from https://github.com/Automattic/wp-calypso/blob/trunk/client/my-sites/customer-home/components/celebrate-launch-modal.jsx

...ckages/jetpack-mu-wpcom/src/features/wpcom-dashboard-widgets/wpcom-launchpad-widget/index.js

youknowriad · 2025-01-28T09:46:19Z

A couple things I noticed:

When I launch a site, the launch button remains, I actually wonder if we should refresh the page instead of removing the widget (and the button) manually, for maintainability reasons. You mentioned that it's possible to render the "launch confirmation modal" using a query string, maybe we should use that instead.
I have an unlaunched site (although I tweaked the options to get into this state) where I site the launchpad but it's totally empty. I wonder how is this possible.

youknowriad · 2025-01-28T09:48:04Z

projects/packages/jetpack-mu-wpcom/package.json

@@ -73,6 +76,8 @@
 		"@wordpress/url": "4.16.0",
 		"clsx": "2.1.1",
 		"debug": "4.4.0",
+		"events": "^3.3.0",
+		"i18n-calypso": "7.0.0",


This one is interesting, we have some components that use this, and others that use @wordpress/i18n. What's the story there? Maybe @jsnajdr knows. How to decide what to use...

So I think ideally we should switch to @wordpress/i18n. But I don't want to trigger string changes for this PR. Also, there's some use cases that can't be easily done with @wordpress/i18n such as strings with HTML elements inside of them (I think).

Also, there's some use cases that can't be easily done with @wordpress/i18n such as strings with HTML elements inside of them (I think).

I think we have createInterpolateElement for that use-case. So I think we're covered there.

Ok, looking a that, it does work a bit differently, and the strings would still have to change. I guess that could be fine.

I may be wrong, but I don't think that translation strings using i18n-calypso's translate() function would even be picked up, only the @wordpress/i18n-style __(), _x(), and so on.

We've generally avoided @automattic/components for similar reasons. It has (or has had in the past, anyway) a lot of stuff that's specific to Calypso that doesn't work so well in Jetpack.

ellatrix · 2025-01-28T09:51:57Z

Thanks, I'll investigate! Sure, the query string might be ok in this case. I guess it's fine to reload for this action.

ellatrix · 2025-01-28T13:40:26Z

A couple things I noticed:

When I launch a site, the launch button remains, I actually wonder if we should refresh the page instead of removing the widget (and the button) manually, for maintainability reasons. You mentioned that it's possible to render the "launch confirmation modal" using a query string, maybe we should use that instead.

I have an unlaunched site (although I tweaked the options to get into this state) where I site the launchpad but it's totally empty. I wonder how is this possible.

Both addressed :)

youknowriad · 2025-01-28T13:45:38Z

jetpack-downloader doesn't seem to work for me at the moment.

youknowriad · 2025-01-28T13:51:59Z

I still see the empty widget, I don't know if it's jetpack downloader not working properly or if the fix didn't work properly

youknowriad · 2025-01-28T13:57:55Z

So it's definitely jetpack downloader (I don't know why yet)

youknowriad · 2025-01-28T15:16:54Z

...ckages/jetpack-mu-wpcom/src/features/wpcom-dashboard-widgets/wpcom-launchpad-widget/index.js

+ *
+ * @return {Function} A ref callback.
+ */
+function useSetHrefBase() {


What is this weird hook

So currently some of the links in Launchpad are relative. These are supposed to be wordpress.com links, so we need to adjust the base. There other wp-admin links are absolute and they are correct.

Can we instead have a prop for the component instead (maybe as a follow-up) to make the component calypso agnostic.

We can try!

youknowriad

The duplication is not ideal, but it should be ok for now.

github-actions · 2025-01-29T15:30:15Z

Code Coverage Summary

Coverage changed in 2 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/wpcom-dashboard-widgets/wpcom-dashboard-widgets.php	0/71 (0.00%)	0.00%	17 💔
projects/plugins/jetpack/extensions/store/membership-products/resolvers.js	56/106 (52.83%)	0.94%	-1 💚

Full summary · PHP report · JS report

ellatrix · 2025-01-29T15:50:39Z

Let's do it :)

This reverts commit 923e295.

anomiex · 2025-01-29T21:29:12Z

pnpm-lock.yaml

@@ -9284,6 +9494,10 @@ packages:
  [email protected]:
    resolution: {integrity: sha512-QADzlaHc8icV8I7vbaJXJwod9HWYp8uCqf1xa4OfNu1T7JVxQIrUgOWtHdNDtPiywmFbiS12VjotIXLrKM3orQ==}

+  [email protected]:


FYI: https://github.com/Automattic/jetpack/security/dependabot/94

This reverts commit 923e295.

This reverts commit 3c5c869.

ellatrix changed the title ~~Add/dashboard launch steps~~ MU WPCOM: dashboard: add launchpad Jan 16, 2025

github-actions bot added [mu wpcom Feature] Wpcom Dashboard Widgets [Package] Jetpack mu wpcom WordPress.com Features [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh [Status] In Progress labels Jan 16, 2025

github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 16, 2025

ellatrix added the [Type] Task label Jan 16, 2025

ellatrix force-pushed the add/dashboard-launch-steps branch from cae4a82 to 26a557a Compare January 16, 2025 20:49

ellatrix force-pushed the add/dashboard-launch-steps branch from 26a557a to 1a7922f Compare January 22, 2025 14:15

ellatrix marked this pull request as ready for review January 22, 2025 15:05

ellatrix commented Jan 22, 2025

View reviewed changes

ellatrix force-pushed the add/dashboard-launch-steps branch from 712aee4 to 85f4aed Compare January 22, 2025 15:25

github-actions bot added the [mu wpcom Feature] Launchpad label Jan 22, 2025

ellatrix force-pushed the add/dashboard-launch-steps branch from f65772b to 498f09a Compare January 22, 2025 16:23

ellatrix commented Jan 23, 2025

View reviewed changes

ellatrix force-pushed the add/dashboard-launch-steps branch from 99f805c to b0b8bfd Compare January 23, 2025 16:15

ellatrix added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 23, 2025

ellatrix force-pushed the add/dashboard-launch-steps branch from b0b8bfd to 97088ad Compare January 23, 2025 16:23

ellatrix mentioned this pull request Jan 26, 2025

Untangle My Home Automattic/wp-calypso#95386

Open

youknowriad reviewed Jan 27, 2025

View reviewed changes

...ckages/jetpack-mu-wpcom/src/features/wpcom-dashboard-widgets/wpcom-launchpad-widget/index.js Outdated Show resolved Hide resolved

ellatrix force-pushed the add/dashboard-launch-steps branch from 97088ad to ad0f173 Compare January 27, 2025 13:42

youknowriad reviewed Jan 28, 2025

View reviewed changes

ellatrix force-pushed the add/dashboard-launch-steps branch from 3fd191d to 3469f65 Compare January 28, 2025 13:38

youknowriad reviewed Jan 28, 2025

View reviewed changes

youknowriad previously approved these changes Jan 28, 2025

View reviewed changes

ellatrix force-pushed the add/dashboard-launch-steps branch from fe094a0 to c88dcb0 Compare January 28, 2025 16:08

ellatrix added 10 commits January 29, 2025 16:14

MU WPCOM: dashboard: add launchpad

3e736b5

changelog

3329d42

Add option default value

7af23ee

Adjust relative links

909d1a7

Add celebrate modal

6aa865e

track

54a4fd3

Explicitly set context

70dd19b

Fix conditions to render widget

852002a

Use query param for modal

550f106

Render modal separately

2dfa068

ellatrix dismissed youknowriad’s stale review via 2dfa068 January 29, 2025 15:15

ellatrix force-pushed the add/dashboard-launch-steps branch from c88dcb0 to 2dfa068 Compare January 29, 2025 15:15

ellatrix merged commit 923e295 into trunk Jan 29, 2025
80 checks passed

ellatrix deleted the add/dashboard-launch-steps branch January 29, 2025 15:50

github-actions bot removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] In Progress labels Jan 29, 2025

ellatrix added a commit that referenced this pull request Jan 29, 2025

Revert "MU WPCOM: dashboard: add launchpad (#41138)"

1917198

This reverts commit 923e295.

ellatrix mentioned this pull request Jan 29, 2025

Revert "MU WPCOM: dashboard: add launchpad" #41403

Merged

anomiex reviewed Jan 29, 2025

View reviewed changes

ellatrix added a commit that referenced this pull request Jan 30, 2025

Revert "MU WPCOM: dashboard: add launchpad (#41138)" (#41403)

3c5c869

This reverts commit 923e295.

ellatrix added a commit that referenced this pull request Jan 30, 2025

Revert "Revert "MU WPCOM: dashboard: add launchpad (#41138)" (#41403)"

0e06479

This reverts commit 3c5c869.

ellatrix mentioned this pull request Jan 30, 2025

MU WPCOM: dashboard: add launchpad #41434

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MU WPCOM: dashboard: add launchpad #41138

MU WPCOM: dashboard: add launchpad #41138

ellatrix commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

ellatrix Jan 22, 2025

youknowriad Jan 28, 2025

ellatrix Jan 23, 2025

youknowriad commented Jan 28, 2025

youknowriad Jan 28, 2025

ellatrix Jan 28, 2025

youknowriad Jan 28, 2025

ellatrix Jan 28, 2025

anomiex Jan 29, 2025

ellatrix commented Jan 28, 2025

ellatrix commented Jan 28, 2025

youknowriad commented Jan 28, 2025

youknowriad commented Jan 28, 2025

youknowriad commented Jan 28, 2025

youknowriad Jan 28, 2025

ellatrix Jan 28, 2025

youknowriad Jan 28, 2025

ellatrix Jan 29, 2025

youknowriad left a comment

github-actions bot commented Jan 29, 2025

ellatrix commented Jan 29, 2025

anomiex Jan 29, 2025

MU WPCOM: dashboard: add launchpad #41138

MU WPCOM: dashboard: add launchpad #41138

Conversation

ellatrix commented Jan 16, 2025 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jan 16, 2025 • edited Loading

github-actions bot commented Jan 16, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

youknowriad commented Jan 28, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ellatrix commented Jan 28, 2025

ellatrix commented Jan 28, 2025

youknowriad commented Jan 28, 2025

youknowriad commented Jan 28, 2025

youknowriad commented Jan 28, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

youknowriad left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 29, 2025

Code Coverage Summary

ellatrix commented Jan 29, 2025

Choose a reason for hiding this comment

ellatrix commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading

github-actions bot commented Jan 16, 2025 •

edited

Loading